backupccl: enable skipped test #40639
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
spaskob
force-pushed
the
backup-flaky-jc-test
branch
2 times, most recently
from
6427c5c to
2d95b7b
Compare
|
Do you know what this test failure on teamcity is about? It looks like a timeout. |
|
it's a test failure due to a race condition. the backup job every now and
then completes before it realizes it is paused.
…On Wed, Sep 11, 2019 at 12:15 PM Lucy Zhang ***@***.***> wrote:
Do you know what this test failure on teamcity is about? It looks like a
timeout.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#40639?email_source=notifications&email_token=AANL63ZLBSLRWEULAQ5QZZ3QJEKR7A5CNFSM4IVKMSV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6PBH4Q#issuecomment-530453490>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AANL6326VIDC3TPHXJTRQ33QJEKR7ANCNFSM4IVKMSVQ>
.
|
The test was flaky and hence skipped for quite sometime. I wasn't able to fix it in it's current form because of the complexity of how we enable job control statements today. This will be revisited once we have a saner implementation. The folloup is tracked at cockroachdb#40638. Touches cockroachdb#40638. Fixes cockroachdb#24136. Release notes (bug fix): none.
spaskob
force-pushed
the
backup-flaky-jc-test
branch
from
2d95b7b to
9a4b62d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test was flaky and hence skipped for quite sometime.
I wasn't able to fix it in it's current form because of
the complexity of how we enable job control statements
today. This will be revisited once we have a saner
implementation. The folloup is tracked at #40638.
Touches #40638.
Fixes #24136.
Release notes (bug fix): none.